Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom mvc setup method to testserver base class #16545

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

lars-erik
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Description

In order to use UmbracoTestServerTestBase with view files outside the test project, we need to be able to customize the IMvcBuilder setup. This addition opens up the setup so that the builder can be modified during setup.

For instance:

image

I would love for this to be backported to 13 as well.
(Here's to hoping all the bugs aren't found yet)

Copy link

github-actions bot commented Jun 3, 2024

Hi there @lars-erik, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@lars-erik lars-erik changed the title Added custom mvc setup method to testserver base class Add custom mvc setup method to testserver base class Jun 3, 2024
@georgebid
Copy link
Contributor

Hey @lars-erik, thank you for your PR 😄 someone on the core collaborators team will review this soon.

@georgebid georgebid self-assigned this Jun 21, 2024
@georgebid georgebid merged commit de74ae4 into umbraco:contrib Jun 21, 2024
14 checks passed
@georgebid
Copy link
Contributor

Hey @lars-erik! I have checked your PR and I am happy to merge this in 🚀 Thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants