V13: Set request culture for VirtualPageController #16572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16555.
Following #16218
VirtualPageController
requests no longer hit theUmbracoRouteValueTransformer
. This had the side effect that the request culture was no longer properly set in theVariationContext
andPublishedRequest
.To fix this I've:
FindDomain
intoFindDomain
andFindAndSetDomain
RouteDomain
andUpdateVariationContext
UpdateVariationContext
beforeFindContent
is invoked, ensuring that the variation context is correctly configured for finding the contentFindDomain
to ensure thePublishedRequest
andVariationContext
have the correct cultures configured.Testing
Configure a virtual page controller like in the issue, and ensure that the culture specified in the domains is set correctly. You can check it like so: