Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Build and release the type declarations of the Backoffice to npm #16718

Merged
merged 12 commits into from
Jul 1, 2024

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Jul 1, 2024

Description

Fixes #16719

The CMS ships with a bundled, non-declarative version of the Backoffice, but for NPM, we need to ship the type declarations. This PR adds a parallel job that aims to build the npm-version of the Backoffice before the myget/npm stages are required.

Other benefits

  • Separated the Backoffice install into its own template to re-use the same npm cache/install/version in 3 places
  • Now calculating the correct version also for the Backoffice shipped with the CMS (one of the API calls would give a static version before)
  • Shaved off almost 1 minute of the Build stage

The new job finishes in 3m 26s usually, which is long before the "Build Umbraco CMS" job finishes, so it doesn't add to the total build time:

image

@iOvergaard iOvergaard marked this pull request as ready for review July 1, 2024 08:31
@iOvergaard iOvergaard requested a review from Zeegaan July 1, 2024 09:53
@Zeegaan
Copy link
Member

Zeegaan commented Jul 1, 2024

LGTM 👍

@Zeegaan Zeegaan merged commit 2122af7 into release/14.1 Jul 1, 2024
12 of 14 checks passed
@Zeegaan Zeegaan deleted the v14/bugfix/nonbundled-npm-package branch July 1, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants