Move ReservedFieldNames to type configuration endpoints #16735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elit0451
requested changes
Jul 4, 2024
src/Umbraco.Cms.Api.Management/ViewModels/Member/MemberConfigurationResponseModel.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/ViewModels/Media/MediaConfigurationResponseModel.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/ViewModels/Document/DocumentConfigurationResponseModel.cs
Outdated
Show resolved
Hide resolved
| DataTypesCanBeChanged = _dataTypesSettings.CanBeChanged, | ||
| DisableTemplates = _umbracoFeatures.Disabled.DisableTemplates, | ||
| UseSegments = _segmentSettings.Enabled, | ||
| ReservedFieldNames = _reservedFieldNamesService.GetDocumentReservedFieldNames(), |
There was a problem hiding this comment.
Do we want to rename IReservedFieldNamesService.GetDocumentReservedFieldNames() to GetDocumentTypeReservedFieldNames, etc.?
There was a problem hiding this comment.
I opted not to, since it seemed like a lot of extra obsolete methods and stuff for not a lot of gain 😄
src/Umbraco.Cms.Api.Management/Controllers/MemberType/ConfigurationMemberTypeController.cs
Outdated
Show resolved
Hide resolved
…ationMemberTypeController.cs Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
elit0451
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
ReservedFIeldNamesproperty into configuration endpoints for Document, Media, and Member, since these are required when creating the type, not the entity.Testing
Request the endpoints and ensure they work