V13: RTE Blocks editable after save #16864
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.01 (5.31 -> 5.30)
- Declining Code Health: 3 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method tinymce.service.js: tinyMceService.initializeEditor
- Large Method umb-rte-block.component.js: umbRteBlockController.onInit
- Complex Method blockeditormodelobject.service.js: blockEditorModelObjectFactory.load
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ Getting worse: Complex Method
blockEditorModelObjectFactory.load increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.50 to 4.53, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in src/Umbraco.Web.UI.Client/src/common/services/tinymce.service.js
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1298 to 1311, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 1554 in src/Umbraco.Web.UI.Client/src/common/services/tinymce.service.js
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ Getting worse: Complex Method
tinyMceService.initializeEditor already has high cyclomatic complexity, and now it increases in Lines of Code from 325 to 338. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1554 in src/Umbraco.Web.UI.Client/src/common/services/tinymce.service.js
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Bumpy Road Ahead
tinyMceService.initializeEditor increases from 6 to 7 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ Getting worse: Large Method
umbRteBlockController.onInit increases from 81 to 85 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.component.js
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.90 to 5.00, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.