Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13: fix 16663 #16866

Merged
merged 4 commits into from
Aug 13, 2024
Merged

V13: fix 16663 #16866

merged 4 commits into from
Aug 13, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Aug 5, 2024

Fixes #16663

This PR includes the changes of #16864 as that solved a build issue.

The problem that is not clearly known by this reporter, is that if a Block shared UDI with another block it will be problematic in the front-end cache, as we use the block UDI as its identifier. This means we always have to make sure that blocks are unique.

This PR registres a Backoffice Clipboard Paste Resolver, which updates the UDIs of Blocks of an RTE with new once.

From my testing this is already handled when duplicating documents, so the C# resolver does already handle this case. — Just a note to mention that, that case is already handled.

@nielslyngsoe nielslyngsoe changed the base branch from contrib to v13/dev August 5, 2024 12:59
@leekelleher leekelleher self-requested a review August 5, 2024 13:39
@leekelleher leekelleher self-assigned this Aug 5, 2024
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/services/tinymce.service.js
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, blocks pasted into the RTE (from the blocks clipboard) have a unique UDI. 👍

@leekelleher leekelleher merged commit 9d94658 into v13/dev Aug 13, 2024
3 of 6 checks passed
@leekelleher leekelleher deleted the v13/bugfix/16663 branch August 13, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocks in RTE content doesn't gets updated when you use the clipboard to copy
2 participants