U4-6593 - After sort, reset the TinyMCE editors with previous settings #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shazwazza
added a commit
that referenced
this pull request
May 7, 2015
U4-6593 - After sort, reset the TinyMCE editors with previous settings
|
Testing this now. I can replicate the original issue. Thanks a ton!! |
|
FWIW, we have (had) similar issue in Archetype, I had to disable the RTE from updating during our custom event. Haven't really found the root of the issue. |
|
Might be worth having a look at this updated code to see if it's the same issue |
|
Yup 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that when resetting the RTEs, the method tinyMCE.execCommand('mceAddEditor') uses the settings of the currently active RTE to create the new RTE. And these settings contain reference to control.value, thus setting all the reset editors to the same model value.