-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Relation types #1474
Merged
Merged
Bugfix: Relation types #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…braco.CMS.Backoffice into bugfix/relation-types
leekelleher
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality this works well, all as expected. I did notice a few cosmetic issues, which could be picked up on later.
On Relations overview...
- Large gap above the table, (due to the empty
<umb-collection-toolbar>
)
On Relation Type detail view...
- Missing breadcrumbs
- Missing a back button, (or if we have a UI pattern for going back to a Collection view?)
- Whilst relations are loading, the UI says "No relations found" for a moment. We could have a
<uui-loading>
? - For "Related Document" and "Related Media", in the info box, the "Parent Type" and "Child Type" are both empty. I believe this is a server/data concern, (as it's missing from the API response), but it's whether we do anything about this in the UI?
- Wondering if the Relation's Parent and Child should be able to open the corresponding item editor? (although, this may open a can of worms)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Merges together with PR: umbraco/Umbraco-CMS#15910
Description
This PR reimplements the relation types and relations UI. The UI has been implemented as Read Only because it doesn't make sense to create relation types in the UI, as they also need a server implementation. We have also removed the tree for relation types as they can't be nested or support folders.
The UI is now simplified as a list of relation types. When you navigate to a relation type you can see all relations for that type including the details for the relation type.
Relations on a relation-type detail workspace are paginated and will show 50 relations per page.
Demo:
Kapture.2024-03-23.at.19.42.37.mp4
With the UI updates, we have also aligned the repositories so they follow the same naming as the rest of our repositories.
Caution
Breaking Changes:
Changes to Relation Types
UmbRelationTypeRepository
toUmbRelationTypeDetailRepository
requestById
torequestByUnique
requestRelationsById
methodsave
methodChanges to Relations
UmbRelationRepository
toUmbRelationCollectionRepository
requestChildRelationById
torequestCollection
Known issues