Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Property description, sets max-width for child items #1961

Merged
merged 6 commits into from
May 30, 2024

Conversation

leekelleher
Copy link
Member

Description

In a property description, when an <img> tag is rendered (from Markdown syntax), if the width was wider than the overflow, it would be cut off. This PR adds a style rule to set the max-width: 100% for any child elements.

Screenshot 2024-05-30 105537

This is a partial fix for umbraco/Umbraco-CMS#16499.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1961.westeurope.1.azurestaticapps.net

@iOvergaard
Copy link
Collaborator

I added a new story to test out Markdown (and thereby discovered that pre+code elements caused an overflow, so I fixed that). You can see the story here: https://ambitious-stone-0033b3603-1961.westeurope.1.azurestaticapps.net/?path=/story/umb-property-layout--with-markdown

@leekelleher leekelleher merged commit 7be52c6 into main May 30, 2024
6 checks passed
@leekelleher leekelleher deleted the v14/bugfix/property-description-img-max-width branch May 30, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants