Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Content Type workspace header UI cosmetics #1962

Merged
merged 7 commits into from
May 30, 2024
Merged

Bugfix: Content Type workspace header UI cosmetics #1962

merged 7 commits into from
May 30, 2024

Conversation

leekelleher
Copy link
Member

Description

Cosmetics to Content Type workspace header UIs, to help towards tightening up the layout and aligning a little more with v13 UI.

I've applied the following...

  • Icon picker, added border and positioning, to align with the property group panels
  • Fixed the height of the tabs bar, as it changed when a tab was added
  • Used flexbox for the tab bar actions, e.g. Composition/resize buttons, for spacing consistency
  • Extra height on the "add property" and "add group" buttons, for prominence and alignment with v13 UI
  • Property group's name input, made full width and transparent border, (border shows on hover), to align with v13 UI
  • Added auto-width to the alias input-lock, so that the full alias can be displayed

Before
before

After
after

I have applied these amends to the Document Type, Media Type, Member Type and User Group workspaces.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@leekelleher
Document Type Workspace, icon picker styling
3bef6c0 
Adds button outline look, with square constraints.
@leekelleher
Document Type Workspace, tab bar height
40a0945 
to ensure a minimum height,
as `--uui-size-15` doesn't exist in the UUI library.
@leekelleher
Document Type Workspace, used flexbox for actions
886d2f4 
so to have more control over the layout/spacing.
@leekelleher
Document Type Workspace, extra height for property/group buttons
3a3b3de 
Aligns more with v13 cosmetics, let's the UI breath.
@leekelleher
Document Type Workspace, property group name input
8bdc1d8 
Lets the property-group input take the full-width,
and makes the border transparent (border appears on hover),
to align with v13 cosmetics.
@leekelleher
Document Type Workspace, adds auto-width to alias input
1da77cf
@leekelleher
Aligned header cosmetics
cbb6e53 
from Document Type workspace to Media Type,
Member Type and User Group workspaces.
@leekelleher leekelleher merged commit 800266c into main May 30, 2024
7 checks passed
@leekelleher leekelleher deleted the v14/bugfix/content-type-workspace-ui-cosmetics branch May 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
release/14.1.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leekelleher @iOvergaard