-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: TinyMce Custom Configuration #1978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration upfront
…ize tinyMce, then later on initialize the plugin APIs
… not to overwrite
iOvergaard
changed the title
Feature: TinyMce Configuration
Feature: TinyMce Custom Configuration
Jun 3, 2024
For whoever is reviewing this: The |
leekelleher
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out, works as expected! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some configurations such as
statusbar
,menubar
, and other visuals are invalid to add after the editor has been rendered. To accommodate this, we are adding aconfig
object to the manifest file which essentially supports the same options as the formerCustomConfig
in V13.There is also a fix for async-loaded extensions, which were previously not considered after the editor was rendered. Now we have an observer on the extensions registry and in case a
tinyMcePlugin
is added or removed, we will re-render the editor and merge the new configuration.Types of changes
How to test?
Dev server
VITE_UMBRACO_EXTENSION_MOCKS=on
environment variableYou have to remove these lines from input-tiny-mce.defaults.ts to get the dev server to work:
CMS
tinyMcePlugin
and attempt to add configurationhost
andeditor
, which you can use to interact with the editor (this is already so before this fix, but make sure this hasn't been broken)Screenshots (if appropriate)