Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Bundling data type package #1981

Merged
merged 17 commits into from
Jun 6, 2024
Merged

Chore: Bundling data type package #1981

merged 17 commits into from
Jun 6, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jun 4, 2024 •
edited
Loading

Description

Please review #1980 first

See #1977 for more details about the bundling changes.

This PR adds bundling for the Data Type package.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen marked this pull request as ready for review June 4, 2024 19:53
leekelleher
leekelleher approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out

  • ✅ Assets minified
  • ✅ DataType workspace still works as expected
  • ✅ Checked DocumentType/MediaType workspaces (adding/updating data-types)
  • ✅ Checked Documents/Media workspaces, that they load and save okay

@leekelleher leekelleher merged commit 7d660bd into main Jun 6, 2024
6 checks passed
@leekelleher leekelleher deleted the v14/chore/bundling-data-type branch June 6, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

@iOvergaard iOvergaard Awaiting requested review from iOvergaard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @leekelleher