Bugfix: Installer does not take the minimum password length into account #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I THINK this is now ready to go, but if someone is able to review it I'd be grateful |
this optimizes Lit's update checker so that the template is only re-rendered if the actual number changes, whereas otherwise it would re-render when the object is set again
iOvergaard
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
I updated it slightly so that we optimize for Lit's update checker by extracting the minimum password length into its own state variable. This has the effect that the template is only re-rendered if the actual number changes, whereas otherwise it would re-render when the object is set again.
LGTM.
iOvergaard
changed the title
|
Thanks @iOvergaard I must admit the architecture of the new Back Office is still a little new to me, but I'm learning :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password length is not correctly being set on the UI element, this is a hacky fix which forces the validation to fail. I need to refactor this (hopefully with some help)
Fixes umbraco/Umbraco-CMS#16601