Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Issue 1170 - Markdown editor is not responsive #1999

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix: Issue 1170 - Markdown editor is not responsive #1999

merged 2 commits into from
Jun 19, 2024

Conversation

jcdcdev
Copy link
Contributor

@jcdcdev jcdcdev commented Jun 14, 2024 •
edited
Loading

Description

Fixes issue umbraco/Umbraco-CMS#16674

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Fixes issue umbraco/Umbraco-CMS#16674

How to test?

Make a Block List Editor, use the MarkDown Editor on the Element Type of the block. See this:

umbraco/Umbraco-CMS#16674

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

madsrasmussen
madsrasmussen approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcdcdev

Everything works as expected. Thanks 🥇

@madsrasmussen madsrasmussen merged commit 3b5aaef into umbraco:main Jun 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
community/pr release/14.1.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcdcdev @madsrasmussen @iOvergaard