Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Readonly mode for Text Area Property Editor UI #2028

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Feature: Readonly mode for Text Area Property Editor UI #2028

merged 3 commits into from
Jun 25, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

This PR adds readonly mode to the Text Area Property Editor UI

How to test

  • Add the readonly attribute to the element through developer tools

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

JesmoDev
JesmoDev approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@JesmoDev JesmoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madsrasmussen madsrasmussen merged commit 9077e80 into main Jun 25, 2024
6 checks passed
@madsrasmussen madsrasmussen deleted the v14/feature/umb-property-editor-ui-textarea-readonly-mode branch June 25, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesmoDev JesmoDev JesmoDev approved these changes

Assignees
No one assigned
Labels
release/14.1.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsrasmussen @JesmoDev @iOvergaard