Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Content type editor keyboard navigation #2041

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Bugfix: Content type editor keyboard navigation #2041

merged 3 commits into from
Jun 25, 2024

Conversation

JesmoDev
Copy link
Contributor

Fixes: https://github.com/umbraco/Umbraco.CMS.Backoffice/issues/1905
Enables the user to focus the trash button with keyboard navigation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

nielslyngsoe
nielslyngsoe reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nielslyngsoe nielslyngsoe merged commit 3bffc6c into main Jun 25, 2024
6 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/content-type-editor-keyboard-nav branch June 25, 2024 11:41
@iOvergaard iOvergaard mentioned this pull request Jun 25, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
release/14.1.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesmoDev @nielslyngsoe @iOvergaard