Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "Disable text and handwriting data collection" missing #369

Closed
TobyGiacometti opened this issue Jun 3, 2024 · 4 comments
Closed

[Bug]: "Disable text and handwriting data collection" missing #369

TobyGiacometti opened this issue Jun 3, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@TobyGiacometti
Copy link

TobyGiacometti commented Jun 3, 2024 •
edited
Loading

Disable OS Data Collection/Disable text and handwriting data collection is missing in the web app since version 0.13.4. Looks like it is caused by a syntax error:

https://github.com/undergroundwires/privacy.sexy/blob/8341411be434c6d145e942b1792020ccf02f58c8/src/application/collections/windows.yaml#L4315

The mapping for the Disable location access category is missing a dash.
@TobyGiacometti TobyGiacometti added the bug Something isn't working label Jun 3, 2024
@undergroundwires
Copy link
Owner

Thanks for the great bug report @TobyGiacometti. It gives all the necessary information and you identify the source of the bug. In addition to fixing the bug on place you show, I will:

  1. Add stricter YAML linting, current YAML linter is not effective.
  2. Add additional in compiler for unnecessary properties.
  3. Add automated YAML schema validation as standard YAML schema support its.

This would prevent similar issues in future through automated tests and provide the necessary quality gates.

undergroundwires added a commit that referenced this issue Jun 13, 2024
@undergroundwires
Add object property validation in parser #369
6ecfa9b 
This commit introduces stricter type validation across the application
to reject objects with unexpected properties, enhancing the robustness
and predictability of data handling.

Changes include:

- Implement a common utility to validate object types.
- Refactor across various parsers and data handlers to utilize the new
  validations.
- Update error messages for better clarity and troubleshooting.
@undergroundwires
Copy link
Owner

Adding stricter validation in compiler/parser and YAML schema, I see that:

  • Some Windows scripts are not being recommended due to incorrect usage of recommended: standard instead of recommend: standard.
  • On macOS, a category having recommendation (recommend property), which is not supported.
  • Some scripts are missing logic due to wrong function calls in Windows
  • Unsupported non-string parameter values are being used relying side-effects of the compiler.

All of this will be fixed and included in next patch.

undergroundwires added a commit that referenced this issue Jun 14, 2024
@undergroundwires
win: fix missing app access recommendations #369
1c2d82d 
This script fixes the recommendation property syntax in Windows script
collection. This syntax error prevented the application from
recommending these scripts, even though they were intended to be
recommended.

Affected scripts:

- Disable app access to physical movement
- Disable app access to eye tracking
- Disable app access to human presence
- Disable app access to screen capture

Previously, these scripts used the unsupported 'recommended: standard'
property, which was identified as incorrect after implementing stricter
property validation.
Related commit: 6ecfa9b
Related issue: #369

This change update these properties to the correct 'recommend:
standard', resolving issues where scripts were not being recommended as
expected.
undergroundwires added a commit that referenced this issue Jun 15, 2024
@undergroundwires
win: fix text and handwriting script omission #369
1a10cf2 
This commit corrects a syntax error that prevented the 'Disable text
and handwriting data collection' script from being included since
version 0.13.4. The error was identified in a previous syntax validation
update (commit 6ecfa9b).

Changes:

- Add a missing dash before 'Disable location access' category. This
  fixes the script omission as reported in the issue #369.
- Remove the dash from `revertCode` of `HarvestContacts` registry
  modification code, fixing the revert code for 'Disable text and
  handwriting data collection' script.

This fix addresses the build errors introduced by stricter syntax checks
and ensures that the script is now properly recognized and executed.
This fix is part of ongoing efforts to improve data handling robustness
and management in script processing.
undergroundwires added a commit that referenced this issue Jun 17, 2024
@undergroundwires
Add schema validation for collection files #369
dc03bff 
This commit improves collection file editing and error detection
directly in the IDE. It adds YAML schema, IDE configuration and
automatic tests to validate it.

- Introduce a YAML schema for collection file.
- Use `yaml-language-server` for enhanced YAML support in VSCode.
- Add telemetry disabling in `configure_vscode.py` to respect user
  privacy.
- Add automated checks to validate YAML file structure against the
  schema.
- Remove unused properties and do not allow them in compiler.
@undergroundwires
Copy link
Owner

This has driven a lot of improvements and bunch of other issues. Special thanks again @TobyGiacometti, great contribution, hope to see you around more.

Released as part of 0.13.5 🚀.

@TobyGiacometti
Copy link
Author

Thank you! You could have just fixed the bug I reported, instead you improved the architecture to prevent such bugs from showing up in the future. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@undergroundwires @TobyGiacometti