Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Unicode 11 #68

Merged
merged 6 commits into from
Oct 30, 2019
Merged

Update to Unicode 11 #68

merged 6 commits into from
Oct 30, 2019

Conversation

Manishearth
Copy link
Member

Hopefully after this the update to Unicode 12 will be straightforward

r? @kwantam or @mbrubeck

@Manishearth
Copy link
Member Author

Travis will fail because of #66

@kwantam
Copy link
Member

kwantam commented Oct 23, 2019

@Manishearth I will try to make time to review this tomorrow.

@Manishearth
Copy link
Member Author

Manishearth commented Oct 23, 2019 via email

@Manishearth
Copy link
Member Author

Manishearth commented Oct 23, 2019 via email

@kwantam
Copy link
Member

kwantam commented Oct 25, 2019

Sorry, obviously I haven't gotten here yet. I hope to have some time in the next two days.

@kwantam
Copy link
Member

kwantam commented Oct 25, 2019

Actually, just did have some time to take a quick look, and to me things look fine and appear to correctly implement the new rules.

But it might still be useful to get a second set of eyes on this (@mbrubeck ?), because my UAX#29 recollection is slightly rusty at this point (no pun intended), so I could have missed something.

@mbrubeck
Copy link
Contributor

I can review it sometime this week.

README.md Outdated Show resolved Hide resolved
@Manishearth
Copy link
Member Author

Oh, I didn't notice the approval. Merging now.

@Manishearth Manishearth merged commit b159d9e into master Oct 30, 2019
@Manishearth Manishearth deleted the unicode-11 branch October 30, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants