Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ssl #42

Closed
nikolasj opened this issue Apr 11, 2023 · 4 comments
Closed

Disable ssl #42

nikolasj opened this issue Apr 11, 2023 · 4 comments

Comments

@nikolasj
Copy link

Hello. Is it possible to disable certificate verification?

ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1129)

in requests package it is verify=False
requests.get(policy_url, headers=HEADERS, auth=(username, password), verify=False)

@pederhan
Copy link
Member

pederhan commented Apr 11, 2023

Yeah, I can add that, although I am using httpx, which might have a slightly different implementation.

I'll probably just expose all httpx.AsyncClient kwargs in the HarborAsyncClient in the constructor at some point, but I'll prioritize adding verify ASAP.

@nikolasj
Copy link
Author

Thank you. A very necessary feature. I would like to try to use your lib

@pederhan
Copy link
Member

I've pushed a new version (0.14.1), try it out and see if it works for you.

@nikolasj
Copy link
Author

It works for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants