Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all httpx.AsyncClient kwargs in HarborAsyncClient constructor #43

Open
1 of 2 tasks
pederhan opened this issue Apr 11, 2023 · 0 comments
Open
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@pederhan
Copy link
Member

pederhan commented Apr 11, 2023

Tasks


For maximum compatibility with all the different setups out there, we should expose every httpx.AsyncClient constructor kwarg, so that users have more control over the HTTP(S) client.

Considerations

This, of course, makes it more difficult to switch to a different underlying HTTP(S) library under the hood, but there are no indications HTTPX will stop being maintained or superseded by a different library. So this seems like an acceptable change.

@pederhan pederhan added the enhancement New feature or request label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant