-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite code generation and upgrade to Pydantic v2 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now with improved code generation
This is a byproduct of using datamodel-code-generator>=0.25.0 which now defaults to timezone-aware datetimes
pederhan
changed the title
Pydantic v2
Rewrite code generation and upgrade to Pydantic v2
Dec 19, 2023
Overwrite models.VulnerabilityItem with models.scanner.VulnerabilityItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the code generation functionality and migrates all models to use Pydantic V2.
Code Generation
All code generation files are now located in the
codegen
directory.The following new Hatch scripts have been added:
generate-main
: Generate main API modelsgenerate-scanner
: Generate scanner API modelsgenerate
: Generate all models (runsgenerate-main
andgenerate-scanner
)The existing
Justfile
has been deleted as a result of migrating these scripts to Hatch.Pydantic V2
Models have been changed to use Pydantic V2, which includes changes to validators and aliases. Changes are documented in the changelog.
Other