Send events to MQ when hosts are renamed. #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terjekv
force-pushed
the
terjekv/Send-events-to-MQ-when-hosts-are-renamed
branch
from
0d6c8bf
to
f9eb441
Compare
|
Clean up merge commit via rebase and force push. |
terjekv
force-pushed
the
terjekv/Send-events-to-MQ-when-hosts-are-renamed
branch
from
f9eb441
to
9471f33
Compare
oyvindhagberg
requested changes
Jun 19, 2023
Comment on lines
+416
to
+411
| if old_name is not None and old_name != instance.name: | ||
| obj = { | ||
| "old_host": old_name, | ||
| "new_host": instance.name, | ||
| "action": "host_updated", | ||
| } | ||
| else: | ||
| obj = { | ||
| "host": instance.name, | ||
| "action": "host_updated", | ||
| } |
There was a problem hiding this comment.
- What do you think about using the same field name whether we have the old name or not? E.g. "host", and "old_host" in addition if it is not None. Might be less confusing to parse.
- How about using the event name "host_renamed" when the host has been renamed? Unless that may also happen without pre_save being called.
There was a problem hiding this comment.
- The reason I opted out of using the same field name (ie,
host) is that I found it ambiguous. Ishostthe new hostname, or the old hostname the recipient knows? If you are going to update an entry based on the event, you need to useold_hostif and only ifold_hostis set, as that's the hostname you know, but in every other version of thehost_updatedevent, you would usehostas the host you know. It's not a big deal, but I felt it being inconsistent. - We can certainly use a new event name. That would make using
hostabove easier as we can define the API for thehost_renameevent.
There was a problem hiding this comment.
- That makes sense, thanks
- Actually, I meant action and not event name. But on second thought let's keep the event name "host" and action "host_updated", that will allow us to extend the functionality in the future if there are other changes to hosts that we want to send events for.
oyvindhagberg
approved these changes
Jul 14, 2023
- Captures the old name with pre_save. - Makes no assumtion on signal consistency in Django... Fixes unioslo#476
terjekv
force-pushed
the
terjekv/Send-events-to-MQ-when-hosts-are-renamed
branch
from
9471f33
to
954920d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476