Further filter fixes. #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We are stuck on drf 3.14.0 due to encode/django-rest-framework#9358 until encode/django-rest-framework#9483 goes into prod, hopefully 3.15.3.
- Add ip support. - Add reverse lookups.
pederhan
reviewed
Aug 8, 2024
- Also reformat as per ruff.
- This should catch the generic issue of filtering on IDs. Ideally we'd do this for every model that supports ID...
- Match exact CIDR or IP within a CIDR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually sets the appropriate filters for most filter sets. A number of attempts at automating the code led nowhere good, so this is where we are.
A lot of this may be cleaned up when DRF 3.15.3 is released as we can bump DRF to 3.15 that officially supports Django5. We are stuck on 3.14.0 due to encode/django-rest-framework#9358 but encode/django-rest-framework#9483 has been merged an hopefully makes 3.15.3.