lint: default pre-commit hooks & fixing

[Borda]

Checklist before merging this PR:

• Mentioned all issues that this PR fixes or addresses.
• Summarized the updates of this PR under Summary.
• Added an entry under Unreleased in the Changelog.

Summary

While working on #2323, I noticed that some simpler formatting issues could be fixed by defaulting to pre-commit hooks.
Also, is it possible that installing this bot would do linting on each PR so this lint step could be removed from all pipelines?

Other Information

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (55ab6c8) to head (650b81c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2324      +/-   ##
==========================================
- Coverage   94.02%   94.01%   -0.02%     
==========================================
  Files         138      138              
  Lines       14201    14187      -14     
==========================================
- Hits        13353    13338      -15     
- Misses        848      849       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dennisbader]

Thanks also for this neat PR @Borda 🚀 💯

Could you add a point to the CHANGELOG.md, describing the changes?

Also good suggestion with the pre-commit ci bot. Might be worth adding.
I assume the ci section in the .pre-commit-config.yaml will only be effective after installing the bot?

[Borda]

Could you add a point to the CHANGELOG.md, describing the changes?

added 0c4d056

I assume the ci section in the .pre-commit-config.yaml will only be effective after installing the bot?

correct

@madtoinou @dennisbader, so ready to land? 🦩

[Borda]

It seems to fail now on upload, so how about making the upload "continue-on-failed"?

[dennisbader]

Hi @Borda, I cannot fix the changelog conflicts (see image below):

Usually I have permission to change it through GitHub, but not for your forked repo.

[Borda]

Usually I have permission to change it through GitHub, but not for your forked repo.

I think I know what the issue is; it is GH policy. If I have it forked with the personal account, it would work as you expect, but it is under an org, so the privileges are different... Let me check if it can be changed...

[dennisbader]

@Borda, sounds good. These Changelog updates I usually apply just before merging, so it would make things a bit easier if I could do it.

Also, I'm just preparing the 0.29.0 release. Will merge your PRs after that, since it's only relevant for developers.

[Borda]

Also, I'm just preparing the 0.29.0 release. Will merge your PRs after that, since it's only relevant for developers.

sure, I have updated the chlog entry so it will be in the new section :)

[dennisbader]

@Borda, the new version is released. If you merge the latest master, I can merge this PR