SQL: Simplify and unify style for all tests #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
With git less, I found two extra whitespaces in your change as I wrote as commens. |
|
BTW, I renamed nano-fuzz to "noise". After your change the SQL parser passed all noise tests! |
This hopefully makes the test conditions more readable and helps avoiding mistakes when modifying them.
b4n
force-pushed
the
sql/tests-cleanup
branch
from
62c4a9c
to
8d076d2
Compare
|
Trailing space fixed on the lines this patch touches (but there are quite a few more in this file) |
b4n
added a commit
that referenced
this pull request
Nov 29, 2014
SQL: Simplify and unify style for all tests
|
Merged, thanks for checking it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully makes the test conditions more readable and helps
avoiding mistakes when modifying them.
(I suggest you use something like
PAGER="less -x4" git diff -wif you want to only review the actual code changes, as there are quite a few space changes mixed in)