Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\s, \S, \w, and \W in regexp #3058

Closed
wants to merge 3 commits into from

Conversation

masatake
Copy link
Member

@masatake masatake commented Jun 9, 2021

See #3034.

masatake and others added 3 commits June 9, 2021 11:20
These are locale-insensitive.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Some changes are not equivalent with original to try more use of extensions.
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #3058 (cb537a1) into master (cab9828) will decrease coverage by 0.00%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         199      199              
  Lines       47611    47646      +35     
==========================================
+ Hits        41579    41606      +27     
- Misses       6032     6040       +8     
Impacted Files Coverage Δ
main/lregex.c 83.54% <81.25%> (-0.06%) ⬇️
parsers/cxx/cxx_parser_function.c 92.46% <0.00%> (-0.23%) ⬇️
parsers/cxx/cxx_parser_tokenizer.c 92.45% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab9828...cb537a1. Read the comment docs.

@masatake
Copy link
Member Author

masatake commented Jun 9, 2021

I confiremd the "replacing approach" works.

@hirooih
Copy link
Contributor

hirooih commented Jun 9, 2021

@masatake san,

Did you close this PR without merging intentionally?

@masatake
Copy link
Member Author

masatake commented Jun 9, 2021

This pull request was just evaluating the idea.

@masatake masatake deleted the sSwW-in-regexp branch June 9, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants