Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append set-cookie headers in web reponse #453

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Jul 20, 2023

πŸ”— Linked issue

Hebilicious/authjs-nuxt#38

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's possible that a Header object has multiple "set-cookie" headers.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious changed the title fix: set-cookie should happen the header fix: set-cookie in webresponse should append the header Jul 20, 2023
@Hebilicious Hebilicious added bug Something isn't working webstd labels Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #453 (6442ee6) into main (0968902) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files          26       26           
  Lines        2698     2698           
  Branches      399      399           
=======================================
  Hits         2098     2098           
  Misses        600      600           
Impacted Files Coverage Ξ”
src/utils/response.ts 69.73% <0.00%> (ΓΈ)

@Hebilicious Hebilicious requested a review from pi0 July 20, 2023 06:52
@pi0 pi0 changed the title fix: set-cookie in webresponse should append the header fix: append set-cookie headers in web reponse Jul 24, 2023
@pi0 pi0 merged commit 27a1bd0 into main Jul 24, 2023
5 of 6 checks passed
@pi0 pi0 deleted the set-cookie-append branch July 24, 2023 09:58
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working webstd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants