This repository has been archived by the owner on Nov 27, 2021. It is now read-only.
Add Reset() #9
Merged
Add Reset() #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unknwon this make it possible to reset i18n on runtime & coverage got from 47.4% -> 51.9% 🎉 |
|
@unknwon do you have any questions about it? |
|
@unknwon should I squash (second commit) the fix in ...? |
squashed ... |
|
@unknwon any change you have time for a review/response? |
unknwon
approved these changes
Mar 21, 2021
|
I can't apply suggestion for you, would you mind applying? Also no need to squash commits within the PR, will squash when merge. |
|
@unknwon thanks :) I did rename it to |
|
hope this is fine now 😅 |
|
Thanks again :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Reset() to reset locale store