Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add support for Svelte 4 #297

Merged
merged 15 commits into from
Sep 2, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -499,15 +499,22 @@ Type Declarations
For SvelteKit, in the `src/app.d.ts` file:

```ts
import 'unplugin-icons/types/svelte'
import 'unplugin-icons/types/svelte4'
```

For Svelte + Vite, in the `src/vite-env.d.ts` file:

```js
/// <reference types="svelte" />
/// <reference types="vite/client" />
/// <reference types="unplugin-icons/types/svelte" />
/// <reference types="unplugin-icons/types/svelte4" />
```

If you're still using Svelte 3, replace the reference to use Svelte 3:
```js
/// <reference types="svelte" />
/// <reference types="vite/client" />
/// <reference types="unplugin-icons/types/svelte3" />
```

<br></details>
Expand Down
2 changes: 1 addition & 1 deletion examples/sveltekit/src/app.d.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/// <reference types="@sveltejs/kit" />
/// <reference types="unplugin-icons/types/svelte" />
/// <reference types="unplugin-icons/types/svelte4" />
2 changes: 1 addition & 1 deletion examples/vite-svelte/src/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/// <reference types="svelte" />
/// <reference types="vite/client" />
/// <reference types="unplugin-icons/types/svelte" />
/// <reference types="unplugin-icons/types/svelte4" />
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,11 @@
"./types/solid": {
"types": "./types/solid.d.ts"
},
"./types/svelte": {
"types": "./types/svelte.d.ts"
"./types/svelte3": {
"types": "./types/svelte3.d.ts"
},
"./types/svelte4": {
"types": "./types/svelte4.d.ts"
},
"./types/vue": {
"types": "./types/vue.d.ts"
Expand Down
File renamed without changes.
11 changes: 11 additions & 0 deletions types/svelte4.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
declare module 'virtual:icons/*' {
import { SvelteComponent } from 'svelte'
import type { SvelteHTMLElements } from 'svelte/elements'
export default class extends SvelteComponent<SvelteHTMLElements['svg']> {}
}

declare module '~icons/*' {
import { SvelteComponent } from 'svelte'
import type { SvelteHTMLElements } from 'svelte/elements'
export default class extends SvelteComponent<SvelteHTMLElements['svg']> {}
}