Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone implementation of configuration-gcp-database #1

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Standalone implementation of configuration-gcp-database #1

merged 2 commits into from
Jan 22, 2024

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 22, 2024

Description of your changes

  • XRD + Composition
  • Reusage of configuration-gcp-network
  • uptest setup

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Local run

=== CONT  kuttl
    harness.go:402: run tests finished
    harness.go:511: cleaning up
    harness.go:553: skipping cluster tear down
    harness.go:554: to connect to the cluster, run: export KUBECONFIG="/Users/xnull/upbound/configuration-gcp-database/kubeconfig"
--- PASS: kuttl (1095.71s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (1095.12s)
PASS
19:07:29 [ OK ] running automated tests

centalized uptest run will follow below

@ytsarev
Standalone implementation of configuration-gcp-database
def9ef4 
* XRD + Composition
* Reusage of configuration-gcp-network
* uptest setup

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev
Add clarification comment on different GCP project usage in e2e run
529d8d3 
Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev
Copy link
Member Author

ytsarev commented Jan 22, 2024

/test-examples

haarchri
haarchri approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ytsarev ytsarev merged commit 79bf07a into upbound:main Jan 22, 2024
2 checks passed
@ytsarev ytsarev deleted the gcp-database-setup branch January 22, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haarchri haarchri haarchri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytsarev @haarchri