Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build submodule and adapt CI pipeline #27

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Oct 4, 2022

Description of your changes

This PR uses upbound/build submodule to build and publish configuration package (specifically upbound/build#203 and upbound/build#207).
It also adapts CI pipeline accordingly.

I have:

How has this code been tested

make build

Ensure package is build under _output/xpkg
CI needs to be tested after merge.

Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turkenh turkenh merged commit dac9a0c into upbound:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants