Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (misleading) comment for setting a single platform #29

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix (misleading) comment for setting a single platform #29

merged 1 commit into from
Oct 6, 2022

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Oct 6, 2022

Description of your changes

See #28 (comment)

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

N/A

@turkenh
Fix comment for setting a single platform
1c16344 
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh requested a review from hasheddan October 6, 2022 11:32
@turkenh turkenh mentioned this pull request Oct 6, 2022
Merged
3 tasks
hasheddan
hasheddan approved these changes Oct 6, 2022
View reviewed changes
Copy link

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenh!

@turkenh turkenh merged commit 91b4b68 into upbound:main Oct 6, 2022
@turkenh turkenh deleted the fix-multi-arch-comment branch October 6, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turkenh @hasheddan