Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functions): use configurations, update to functions #49

Merged
merged 2 commits into from
Jan 24, 2024
Merged

feat(functions): use configurations, update to functions #49

merged 2 commits into from
Jan 24, 2024

Conversation

haarchri
Copy link
Member

Description of your changes

  • change to composition functions
  • enable renovate
  • use configurations like configuration-gcp-network/gke/database

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

--- PASS: kuttl (3042.59s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (3042.09s)
PASS
10:48:15 [ OK ] running automated tests

@haarchri
feat(functions): use configurations, update to functions
d91aadc 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri
Copy link
Member Author

/test-examples

@haarchri haarchri requested a review from ytsarev January 24, 2024 12:17
@haarchri haarchri mentioned this pull request Jan 24, 2024
Closed
3 tasks
ytsarev
ytsarev reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, left some minor comments

Makefile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/app-claim.yaml Show resolved Hide resolved
@haarchri
feat(readme): add family provider for readme
6ba8483 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri requested a review from ytsarev January 24, 2024 19:52
ytsarev
ytsarev approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes

@haarchri haarchri merged commit 1aba27a into main Jan 24, 2024
2 checks passed
@haarchri haarchri deleted the feature/composition-functions branch January 24, 2024 20:32
This was referenced Jan 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarchri @ytsarev