Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Everything #43

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Upgrade Everything #43

wants to merge 13 commits into from

Conversation

Avarei
Copy link

@Avarei Avarei commented Sep 21, 2024

Description of your changes

I recently started using this provider and I noticed two things that need to be fixed before I can use it.

  1. the current image contains a variety of fixable CVEs
  2. the provider sometimes does not detect that a resource has been successfully created and it is never reconciled again.

To fix the CVEs I upgraded various dependencies:

  • switch from the last usable terraform version to the latest version of openTofu
  • upgrade terraform-provider-vault to latest version
  • upgrade other go dependencies with CVEs

Since I still encountered the second issue after the first set of upgrades I also upgraded go to 1.23 and upjet to 1.4.1.

And since then I did not have any issues with resource creation.
Also most CVEs from the previous version are gone.

I also added the three new resources that have been added to the provider in the newest version:

  • vault_config_ui_custom_message
  • vault_plugin
  • vault_plugin_pinned_version

However this PR also comes with a few caveats:

  • I could not get make lint to pass due to typecheck golangci-lint.log
  • Therefore make reviewable fails
    • got it working :)
  • I did not test any new/changed resources

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The provider has been built using make build.all and used in a dev environment for a few days.
It has been deployed to a dev environment and a small selection of resources have been deployed successfully.

Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Squashed commit of the following:

commit c28c581
Author: Tim <32556895+Avarei@users.noreply.github.com>
Date:   Tue Sep 17 08:16:42 2024 +0200

    fix dependency errors

    Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>

commit 3db1b2a
Author: Tim <32556895+Avarei@users.noreply.github.com>
Date:   Tue Sep 17 01:03:48 2024 +0200

    fix more errors

    Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>

commit e26af6f
Author: Tim <32556895+Avarei@users.noreply.github.com>
Date:   Tue Sep 17 00:06:51 2024 +0200

    fix codegen

    Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>

commit 2a007e3
Author: Tim <32556895+Avarei@users.noreply.github.com>
Date:   Mon Sep 16 22:43:25 2024 +0200

    sunken cost fallacy. upgrade everything!

    Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>

commit e043178
Author: Tim <32556895+Avarei@users.noreply.github.com>
Date:   Mon Sep 16 19:36:47 2024 +0200

    try to upgrade upjet to 1.4

    Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>

Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
remove deprecated configuration from .golangci.yml

Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant