Skip to content

Commit

Permalink
Fix percentage formatting in top n regression and improvement tables (#…
Browse files Browse the repository at this point in the history
…77)

In the release candidate report
[here](http://crossbow.voltrondata.com/release_reports/arrow-release-report-15.0.0-rc1.html),
there was an bug in {gt} code that was causing pre-computed percentages
to be multiplied by an additional 100x. This PR tells {gt} that they are
already percentages.

FYI @raulcd @assignUser
  • Loading branch information
boshek committed Jan 17, 2024
1 parent e706fae commit 3020a99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion performance-release-report/R/functions.R
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ top_zscore_table <- function(.data, top_n = 20, direction = c("improvement", "re
arrange(language, suite, name, params) %>%
gt(rowname_col = "language", groupname_col = "suite") %>%
fmt_markdown(columns = "name") %>%
fmt_percent(columns = "analysis_pairwise_percent_change", decimals = 0) %>%
fmt_percent(columns = "analysis_pairwise_percent_change", scale_values = FALSE, decimals = 2) %>%
fmt_number(columns = ends_with("single_value_summary"), decimals = 0) %>%
fmt_number(columns = "analysis_lookback_z_score_z_score", decimals = 2) %>%
cols_label(
Expand Down

0 comments on commit 3020a99

Please sign in to comment.