Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trend plot interactive #64

Merged
merged 22 commits into from
Aug 26, 2023
Merged

Make trend plot interactive #64

merged 22 commits into from
Aug 26, 2023

Conversation

boshek
Copy link
Contributor

@boshek boshek commented Aug 24, 2023

This PR is a draft to address #55. To do this I have ported the report to become a quarto doc rather than rmarkdown and then written the viz in javascript for more interactivity.

Because the way this is implemented, it needs to be served up via https rather than a local html file. So screenshots it is. Here is the default which sets the x-axes to extend to the last 120 days:

image

but we can slide to only look at the last ten days:

image

or look at the past 6 months:

image

Also included here is a tooltip which gives some specific info:

image

I have also updated the build table to include passing runs. Because this adds a significant amount of rows to the table, I've implemented some interactivity for the build table. This looks like this:

image

I am hoping that @raulcd or @assignUser can offer some thoughts on this change.

TODO before merging this:

  • revise the workflow to use quarto instead of rmarkdown
  • final tweaks to polish trend plot
  • implement any suggestions.

@boshek boshek changed the title Trim-view Make trend plot interactive Aug 24, 2023
@assignUser
Copy link
Contributor

Looks cool, I assume it will work via http to (as we can't use ssl on the bucket) and just needs to be served via server?

@assignUser
Copy link
Contributor

With the file from the last run in the PR (served via python -m http.server 8000) I was only able to go back to 1st of july, where your screenshots go further back, is that intentional?

@boshek
Copy link
Contributor Author

boshek commented Aug 24, 2023

With the file from the last run in the PR (served via python -m http.server 8000) I was only able to go back to 1st of july, where your screenshots go further back, is that intentional?

Sort of. The build was struggling with that data and I'm working on implementing the big huge error table differently with some interactivity and column filtering. I think this bonks on some many tabs.

I've made this lookback window configurable here: https://github.com/boshek/crossbow/blob/b5aae8df7ec7c22e67d69f1dff4243158828c0a2/.github/workflows/nightly_dashboard.yml#L70

What do you think is a reasonable default here?

@assignUser
Copy link
Contributor

assignUser commented Aug 24, 2023

Ah nice. We release every quarter so 3-4 months if that is workable?

@boshek
Copy link
Contributor Author

boshek commented Aug 25, 2023

@assignUser I've made some changes and I think this is ready (at least for a review). Thanks for your feedback to this point!

@boshek boshek marked this pull request as ready for review August 25, 2023 16:59
Copy link
Contributor

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! the new filter/dropdown stuff 🤯 Let's merge it and make sure that it also works via s3!

@assignUser assignUser merged commit 4828ea0 into ursacomputing:main Aug 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants