Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cloud benchmark machines for release report #86

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

boshek
Copy link
Contributor

@boshek boshek commented Jun 28, 2024

This PR modifies the performance release report to report on benchmarks collected by cloud machines only. It removes both the ursa-i9-9960x and ursa-thinkcentre-m75q machines in favour of the ec2-m5-4xlarge-us-east-2 and ec2-c6a-4xlarge-us-east-2.

Because the previous release was not benchmarked on those machines we have initiated manual runs of those to facilitate the comparison.

Here are these two runs:

These are benchmarking apache/arrow@7dd1d34 as a baseline so any subsequent render of the release report should set
BASELINE_GIT_COMMIT=7dd1d34074af176d9e861a360e135ae57b21cf96

Then the CONTENDER_GIT_COMMIT can simply be the rc commit.

cc @raulcd and @assignUser

Copy link
Collaborator

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, not an expert on R nor quarto but I am going to merge as @assignUser might be out for some days and we will test this for 17.0.0. @boshek I'll ping you if something fails and we require a fix for the release.

@raulcd raulcd merged commit ee76b67 into ursacomputing:main Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants