Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete quoting for parameters of some CMake commands #8

Open
elfring opened this issue Aug 7, 2014 · 1 comment
Open

Complete quoting for parameters of some CMake commands #8

elfring opened this issue Aug 7, 2014 · 1 comment
Labels

Comments

@elfring
Copy link

elfring commented Aug 7, 2014

Some parameters (like "${PROJECT_SOURCE_DIR}/cmake/modules" and "${CMAKE_CURRENT_BINARY_DIR}/usbproxy.pc") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

@dominicgs
Copy link
Contributor

Oh dear, I've done that everywhere!

Thanks for catching this, my experience with CMake is minimal, so if you have any other tips/comments I would like to hear them.

@dominicgs dominicgs self-assigned this Aug 7, 2014
@dominicgs dominicgs added the bug label Aug 7, 2014
BenGardiner pushed a commit to BenGardiner/USBProxy that referenced this issue Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants