Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated package-lock.json causes incorrect dependencies to be installed #920

Closed
Silic0nS0ldier opened this issue Jan 11, 2019 · 2 comments
Closed

Outdated package-lock.json causes incorrect dependencies to be installed #920

Silic0nS0ldier opened this issue Jan 11, 2019 · 2 comments
Assignees
@Silic0nS0ldier
Labels
confirmed bug Something isn't working
Milestone
4.2.0

Comments

@Silic0nS0ldier
Copy link
Member

An existing package-lock.json causes a mix of old and new dependencies to be installed (some possibly not at all). This causes build scripts to potentially fail (incompatibilities and/or unsatisfied dependencies) when run.

This issue has caused #882 and issues migrating from 4.1.
@Silic0nS0ldier Silic0nS0ldier added the confirmed bug Something isn't working label Jan 11, 2019
@Silic0nS0ldier Silic0nS0ldier added this to the 4.2.0 milestone Jan 11, 2019
@Silic0nS0ldier Silic0nS0ldier self-assigned this Jan 11, 2019
@Silic0nS0ldier Silic0nS0ldier mentioned this issue Jan 11, 2019
Closed
@Silic0nS0ldier
Copy link
Member Author

Looks like the solution to this will involve telling npm to not look at, nor create a lockfile (which it looks like is achievable in a manner that will work with any dependency installation method).

Silic0nS0ldier added a commit that referenced this issue Jan 12, 2019
@Silic0nS0ldier
Fix for #920 and potentially dodgy node dependencies lockfile
4822f14
@Silic0nS0ldier
Copy link
Member Author

This has been fixed in develop. Fix required npm to be told to not use a package-lock.json AND for the lockfile to be deleted if it appears. For the bakery npm installation the lockfile skip logic was modified to use a package.lock file instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Silic0nS0ldier Silic0nS0ldier

Labels
confirmed bug Something isn't working
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
1 participant
@Silic0nS0ldier