Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remaining issues for v11 release #789

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix: remaining issues for v11 release #789

merged 3 commits into from
Sep 5, 2024

Conversation

broofa
Copy link
Member

@broofa broofa commented Aug 8, 2024

Tracking and fixing a few remaining items before pushing out v11 pre-release:

  • Fixed build.sh code that moves "[name]-browser.*" files to "[name].*"
  • Fixed examples/node-esmodules and examples/browser-esmodules code for testing package.json import
  • Removed code from v35.test.ts that depended on "md5-browser.js" and "sha-browser.js", which are no longer present in dist.
  • Fix BrowserStack builds

@ctavan I know you're busy with other stuff these days, but I could use some help with the BrowserStack issue. The browser workflow in Checks runs and passes, but I don't think it's actually doing anything. The log shows all tests as being skipped. Nor is there any meaningful logs in the BS dashboard. For example that run links to this empty output.

'Been this way for awhile. FWIW, I see the same behavior when running the tests locally using this config with wdio -l debug run ./wdio.conf.js.

Anyhow... I'll keep poking at this, but if you have any ideas for what might be going on, I'd be interested in hearing them.

@broofa broofa changed the title fix: browser builds fix: remaining issues for v11 release Aug 8, 2024
@broofa broofa mentioned this pull request Sep 5, 2024
2 tasks
@broofa broofa marked this pull request as ready for review September 5, 2024 20:19
@broofa
Copy link
Member Author

broofa commented Sep 5, 2024

@ctavan 'Finally figured out the BrowserStack issue. Apparently thetest(...) method is no longer defined in the context of browser.spec.js. How...? Why...? Dunno. Probably happened when I updated devDependencies at some point. Switching to it(...) fixes the problem. 'Would've been nice if there'd been some sort of error message in the logs but there wasn't. Just "test skipped". 🤦

Anyhow... that CI check is working again. Note, too, that I've removed the legacy capabilities (chrome@52, FF@51, Edge@15, Saf@11). Once this goes in, we'll only be testing browserVersion: 'latest'.

@broofa broofa merged commit a87be4b into main Sep 5, 2024
12 checks passed
@broofa broofa deleted the fix_browser_build branch September 5, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant