ls: Fix quoting for dirnames with a colon : in recursive mode, and patch the quote-align GNU test

[RenjiSann]

Fixes #6554 and adds a test for it.

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[RenjiSann]

@BenWiederhake @sylvestre @tertsdiepraam ping, if one of you has the time to take a look :)

[sylvestre]

Sorry, i didn't look because your test fails a bunch of jobs:

--- TRY 3 STDERR:        coreutils::tests test_ls::test_ls_recursive_escape_dirname ---
thread 'test_ls::test_ls_recursive_escape_dirname' panicked at tests\common\util.rs:956:40:
called `Result::unwrap()` on an `Err` value: Os { code: 267, kind: NotADirectory, message: "The directory name is invalid." }
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library\std\src\panicking.rs:652
   1: core::panicking::panic_fmt
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library\core\src\panicking.rs:72
   2: core::result::unwrap_failed
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library\core\src\result.rs:1654
   3: enum2$<core::result::Result<tuple$<>,std::io::error::Error> >::unwrap
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081\library\core\src\result.rs:1077
   4: tests::common::util::AtPath::mkdir<ref$<str$> >
             at .\tests\common\util.rs:956
   5: tests::test_ls::test_ls_recursive_escape_dirname
             at .\tests\by-util\test_ls.rs:2204
   6: tests::test_ls::test_ls_recursive_escape_dirname::closure$0
             at .\tests\by-util\test_ls.rs:2201
   7: core::ops::function::FnOnce::call_once<tests::test_ls::test_ls_recursive_escape_dirname::closure_env$0,tuple$<> >
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081\library\core\src\ops\function.rs:250
   8: core::ops::function::FnOnce::call_once
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library\core\src\ops\function.rs:250
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

[RenjiSann]

I have guessed that when using the shell quoting style, with show-control-chars display enabled, ls should quote the name if it does encounter a control character.

Commit 83c1447 handle this case.

EDIT: It seems that in shell mode, control characters induce simple quoting, no matter the status of show_control.

[RenjiSann]

I have made a substantial change in the quoting_style file, regarding the quoting behavior of control characters in shell-* modes.

Even though I am pretty sure this change is sound for ls, it might have repercussions on other utils that use quoting_style

[RenjiSann]

I realize this PR does duplicate the work in #6555.

Let's compare the changes and keep the best of both.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/quote-align is no longer failing!
Congrats! The gnu test tests/rm/rm2 is no longer failing!

[RenjiSann]

Style/Lint jobs are failing due to the clippy bump, but I will rebase the PR once #6592 has landed.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/quote-align is no longer failing!
Congrats! The gnu test tests/rm/rm2 is no longer failing!

[RenjiSann]

I keep finding edge cases : \a is a control character, yet it shall not be escaped in shell mode. I need to rework my solution.

So far:

$ LC_ALL=C /usr/bin/ls --quoting=shell test
 xx?bell   xx?backspace  'xx?tab'  'xx?linefeed'   xx?vtab   xx?formfeed  'xx?carriage'  'xx space'

$ LC_ALL=C ./target/debug/ls --quoting=shell test
'xx?bell'  'xx?backspace'  'xx?tab'  'xx?linefeed'  'xx?vtab'  'xx?formfeed'  'xx?carriage'  'xx space'

I don't see a specific pattern, so I guess we will have to do it by hand.

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/ls/quote-align is no longer failing!

[RenjiSann]

@sylvestre @cakebaker @tertsdiepraam ping (also, is there one of you I should ping in priority for this ?)

[RenjiSann]

@BenWiederhake Just remembered I can notify you as well

[BenWiederhake]

While this does improve the situation significantly, there are still a few closely-related special characters that are handled incorrectly. I would strongly prefer that we fix all ASCII characters in one fell swoop. Can you add tests and handling for these, too?

Specifically:

• --quoting-style=shell: each of the four characters in ]^{} should not be escaped (but we do), = should be escaped (but we don't)
• Note in particular that [ should YES be escaped, and we handle this correctly. Wild.
• Same with --quoting-style=shell

[RenjiSann]

Same with --quoting-style=shell

Did you mean --quoting-style=shell-escape ?

[RenjiSann]

Also, I think you inverted for ^ : with --quoting-style=shell, a caret should be escaped, and we currently don't

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/ls/quote-align is no longer failing!

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/quote-align is no longer failing!

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/ls/quote-align is no longer failing!

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/ls/quote-align is no longer failing!
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!