cp: show mode if target does not have S_IWUSR #6696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the target exists, and does not have the user write bit (S_IWUSR) set, additional information should be added to the overwrite confirmation prompt. This should get the "i-2" test to pass. See uutils#6658.
andrewliebenow
force-pushed
the
fix-issue-6658
branch
from
fe8463e
to
e2a8e86
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Sep 15, 2024
sylvestre
reviewed
Sep 15, 2024
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Sep 16, 2024
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
|
Okay, I thought using the GitHub "update branch" option would do a rebase, sorry about that. |
|
Closed in favor of #6696. |
|
GNU testsuite comparison: |
sylvestre
added a commit
that referenced
this pull request
Sep 18, 2024
* cp: show mode if target does not have S_IWUSR If the target exists, and does not have the user write bit (S_IWUSR) set, additional information should be added to the overwrite confirmation prompt. This should get the "i-2" test to pass. See #6658. * cp: with -i, delete destination if needed --------- Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the target exists, and does not have the user write bit (S_IWUSR) set, additional information should be added to the overwrite confirmation prompt.
This should get the "i-2" test to pass. See
#6658.