-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "delete before copy" logic. Add tests. #6712
base: main
Are you sure you want to change the base?
Fix "delete before copy" logic. Add tests. #6712
Conversation
Also: fix "delete before copy" verbose mode output.
Could you please be more explicit about the issue you are fixing ? thanks |
GNU testsuite comparison:
|
Sorry. The issue is kind of explained in this deleted comment: Lines 1775 to 1779 in b8150f5
If This incorrect check was causing some necessary pre-copy deletions to be skipped, which then caused the copy operation to fail due to lack of write permission. I added tests for this edge case (the ones where the destination file mode is 077, as opposed to 000 in the other "delete before copy" tests). |
GNU testsuite comparison:
|
GNU testsuite comparison:
|
6eabcd1
to
7ac22e6
Compare
GNU testsuite comparison:
|
Also: fix "delete before copy" verbose mode output.