change in comparisons in lines 81 and 132 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison scheme implemented in earlier code would result in an out of bounds error. It was not apparent in the code because the dimensions of the camera being used were symmetric(128x128). However, in the case of a 240x180 camera's event data, the code would throw an error. Proposed change looks to rectify this discrepancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison scheme implemented in earlier code would result in an out of bounds error. It was not apparent in the code because the dimensions of the camera being used were symmetric(128x128). However, in the case of a 240x180 camera's event data, the code would throw an error.
Proposed change looks to rectify this discrepancy.