Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy dns with NOTIMP error #2954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

proxy dns with NOTIMP error #2954

wants to merge 1 commit into from

Conversation

rp-hello
Copy link

Chromium will send SVCB/HTTPS type dns query, which cause dns leak.

To prvent dns leak,

  • If the dns query type is not implemented, should return NOTIMP error, not just send data to original destination.
  • If the dns query has wrong format domain, should return FORMERR error, not send data to original destination.

Copy from #2595

@rp-hello
Copy link
Author

rp-hello commented Mar 31, 2024

Here is similar issue XTLS/Xray-core#3006.
Could we just introduce nonIPQuery option?

  • when nonIPQuery=drop, just return NOTIMP, and this is default behavior
  • when nonIPQuery=skip, follow the original chain, call connWriter.WriteMessage

Copy link
Contributor

It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jul 30, 2024
@xiaokangwang
Copy link
Contributor

I think it would be better if we guard this new behavior behind a flag or option, otherwise it would take significantly longer time decide if a regression is justified.

@xiaokangwang xiaokangwang added the Extensive Review Required Require an extensive review from organization owner, cannot be merged without owner approval label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extensive Review Required Require an extensive review from organization owner, cannot be merged without owner approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants