Refactor improved threading & logging #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Python version in .github/workflows/release.yml - Updated required Python version in README.md - Updated Python version in pyproject.toml - Added Python 3.12 support in tox.ini
- Updated CI workflow to trigger on `dev` branch - Added Python 3.12.* to the matrix for dependency_review job - Adjusted linting workflow to run on the `dev` branch
- Modified GitHub Actions workflow in release.yml - Updated references to `inputs.checkout_branch` to `github.ref_name`
- Added `pr_merge` job to create and merge PRs
- Corrected condition for checking empty directory in core.py
- Adjusted index calculation for 'dev' branch
- Corrected escape sequences in file paths - Used raw string literals for regular expressions
Bumps [selectolax](https://github.com/rushter/selectolax) from 0.3.17 to 0.3.18. - [Release notes](https://github.com/rushter/selectolax/releases) - [Changelog](https://github.com/rushter/selectolax/blob/master/CHANGES.rst) - [Commits](rushter/selectolax@v0.3.17...v0.3.18) --- updated-dependencies: - dependency-name: selectolax dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3 to 4. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@v3...v4) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Feat enhance download manager functionality - Added the option to always use the download manager. - Introduced the `download_manager.open_on_no_matches` config - Introduced the `download_manager.always_open` config - Introduced the `download_manager.no_automatic_downloads` config - Updated default app configuration and config reading. - Updated download manager logic to determine when it should open. - Added additional tests to ensure the proper functioning of the download manager. - Enhanced download manager functionality with the following features: - The download manager now opens in two scenarios: when no matches are found or always, regardless of subtitle count. - Users have control over automatic downloads for subtitles that would have been downloaded by default when always using the download manager. - Updated the `download_manager` method in the `SubsearchCore` class. - Modified the handling of `rejected_subtitles` in the `DownloadManager` class. - Improved sorting and display of subtitles in the `DownloadManager`. - Added automatic downloads based on an acceptance threshold. - Removed temporary zip archives after subtitle extraction.
- Added a Note section for ppl interested in dev builds
- Fixed the reported number of downloaded subtitles in the log and displayed as a toast massage
- Introduced `PropagatingThread` class for propagating exceptions - Implemented `handle_tasks` for managing multiple threads - Enhanced logging for thread start and finish events
- Updated log format in `io_log.py` to include module, lineno, and timestamp
- Updated log calls to match new format in `io_file_system.py`
- Removed `misc.multithreading` option from Subsearch
- Removed `misc.multithreading` option from Subsearch
- Removed unnecessary logging calls in decorators module - Improved conditions in `call_func` and `_CoreSubsearchFuncCondtitons` - Added `capture_call_info` decorator for capturing call information
vagabondHustler
deleted the
chore/refactor_threading_logging/240126180053
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.