remove deletNote() as it was only used in tests

valantic · Aug 1, 2023 · 6e7a4d3 · 6e7a4d3
1 parent 14427df
commit 6e7a4d3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 26 deletions.
diff --git a/src/Repository/ConfigurationRepository.php b/src/Repository/ConfigurationRepository.php
@@ -328,22 +328,6 @@ public function modifyNote(string $className, string $attributeName, ?string $no
         $this->setConfig($config);
     }
 
-    /**
-     * Deletes a class-attribute note.
-     *
-     * @param class-string $className
-     */
-    public function deleteNote(string $className, string $attributeName): void
-    {
-        if (!$this->isClassConfigured($className) || !$this->isAttributeConfigured($className, $attributeName)) {
-            return;
-        }
-
-        $config = $this->getConfig();
-        $config[Configuration::CONFIG_KEY_CLASSES][$className][Configuration::CONFIG_KEY_CLASSES_ATTRIBUTES][$attributeName][Configuration::CONFIG_KEY_CLASSES_ATTRIBUTES_NOTE] = null;
-        $this->setConfig($config);
-    }
-
     /**
      * Given a class name, return the corresponding config for $attribute.
      *

diff --git a/tests/Config/ConstraintTest.php b/tests/Config/ConstraintTest.php
@@ -81,16 +81,8 @@ public function testWriteNote(): void
         $configurationRepository->modifyNote($this->className, $this->attributeName, 'ipsum');
         $this->assertSame('ipsum', $configurationRepository->getNoteForAttribute($this->className, $this->attributeName));
 
-        $configurationRepository->deleteNote($this->className, $this->attributeName);
-        $configurationRepository->deleteNote($this->className, $this->attributeName);
-        $this->assertNull($configurationRepository->getNoteForAttribute($this->className, $this->attributeName));
-
-        $configurationRepository->deleteNote($this->className, $this->attributeNameOther);
-        $this->assertNull($configurationRepository->getNoteForAttribute($this->className, $this->attributeNameOther));
-
-        $this->assertNull($configurationRepository->getNoteForAttribute($this->classNameOther, $this->attributeName));
-        $configurationRepository->deleteNote($this->classNameOther, $this->attributeName);
-        $this->assertNull($configurationRepository->getNoteForAttribute($this->classNameOther, $this->attributeName));
+        $configurationRepository->modifyNote($this->className, $this->attributeName, '');
+        $this->assertSame('', $configurationRepository->getNoteForAttribute($this->className, $this->attributeName));
     }
 
     public function testWriteDoubleAdd(): void