Add (or remove) deprecation notice for with: option

[alexdunae]

https://github.com/validates-email-format-of/validates_email_format_of/blob/master/lib/validates_email_format_of.rb#L58-L62

We should either log something if it's going to be deprecated, or de-deprecate and just let it live on.

[betesh]

Personally, I don't really see any use for it. Most ActiveModel email validation that's not using this gem is instead using validates_format_of :email, :with => ..., and the main benefit of our gem is that nobody has to rewrite the Regex. So if someone wants to write a custom Regex, I don't see the advantage to using this gem over ActiveModel's native FormatValidator.

So I'm all for deprecating it. Are there any reasons not to?

[alexdunae]

The only use case in can think of is if someone has a mixed list of emails, some proper, some not, and wants to be able to selectively override. Pretty tenuous...

I say deprecate then remove.

Dialect // 778-992-2229 // dialect.ca

On Aug 15, 2014, at 11:34 AM, betesh notifications@github.com wrote:

Personally, I don't really see any use for it. Most ActiveModel email validation that's not using this gem is instead using validates_format_of :email, :with => ..., and the main benefit of our gem is that nobody has to rewrite the Regex. So if someone wants to write a custom Regex, I don't see the advantage to using this gem over ActiveModel's native FormatValidator.

So I'm all for deprecating it. Are there any reasons not to?

—
Reply to this email directly or view it on GitHub.