Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains starting with numbers fail validation #88

Closed
ken-schwartz opened this issue Aug 8, 2022 · 1 comment · Fixed by #89
Closed

Domains starting with numbers fail validation #88

ken-schwartz opened this issue Aug 8, 2022 · 1 comment · Fixed by #89

Comments

@ken-schwartz
Copy link

ken-schwartz commented Aug 8, 2022 •
edited
Loading

Works in 1.6.3
Fails in 1.7.x

Email addresses with domains that start with numbers are failing validation. Below are some generic examples:

  • anything@123domain.com -- INVALID in 1.7.x, VALID in 1.6.3
  • anything@domain123.com -- VALID in all versions

Please let me know if there is any more information you need!
alexdunae added a commit that referenced this issue Aug 8, 2022
@alexdunae
Allow domain parts beginning with numbers
bf6ac3e 
The addendum in RFC 1123 was missing previously

Fixes #88
@alexdunae alexdunae mentioned this issue Aug 8, 2022
Merged
@alexdunae
Copy link
Contributor

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow domain parts beginning with numbers validates-email-format-of/validates_email_format_of
2 participants
@alexdunae @ken-schwartz