Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1761 for Bangladesh and Myanmar Mobile Validation and Test #1813

Merged
merged 7 commits into from
Nov 17, 2021
Merged

Fixes #1761 for Bangladesh and Myanmar Mobile Validation and Test #1813

merged 7 commits into from
Nov 17, 2021

Conversation

ferdousulhaque
Copy link
Contributor

Fixes and Addition, please ignore the previous pull request.

  • Bangladesh Mobile Number validation was incorrect, fixed that and added test for the relevant part.
  • Added new Myanmar Mobile Number validation and test
  • Updated README.md for the new country Myanmar

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #1813 (1ce9c43) into master (47ee5ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1813   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2059      2059           
  Branches       464       464           
=========================================
  Hits          2059      2059
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ee5ad...1ce9c43. Read the comment docs.

tux-tn
tux-tn requested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ferdousulhaque and thank you for your PR!
Can you please address the comments below?

src/lib/isMobilePhone.js Outdated Show resolved Hide resolved
src/lib/isMobilePhone.js Outdated Show resolved Hide resolved
@tux-tn tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Oct 27, 2021
tux-tn
tux-tn requested changes Nov 8, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for addressing my comments. Can you please fix merge conflicts and we should be good to go

@ferdousulhaque
Copy link
Contributor Author

@tux-tn conflicts resolved. :)

tux-tn
tux-tn approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🧹 needs-update For PRs that need to be updated before landing and removed 🧹 needs-update For PRs that need to be updated before landing labels Nov 10, 2021
@ferdousulhaque
Copy link
Contributor Author

@tux-tn Please help to add tag hacktoberfest-accepted. Thank you a lot 🎉

@tux-tn
Copy link
Member

tux-tn commented Nov 10, 2021

Done

@profnandaa profnandaa merged commit 5e1c0cd into validatorjs:master Nov 17, 2021
@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ArthurMaverick ArthurMaverick mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
@wambugucoder wambugucoder mentioned this pull request May 30, 2024
Open
@zolamk zolamk mentioned this pull request Jun 12, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jun 12, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Jun 13, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jun 13, 2024
Closed
This was referenced Jun 14, 2024
Closed
Closed
@DefenderK DefenderK mentioned this pull request Jun 14, 2024
Closed
This was referenced Jun 18, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 28, 2024
Closed
Closed
Closed
This was referenced Jul 10, 2024
Closed
Closed
Closed
@rm-neilsondesa rm-neilsondesa mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jul 18, 2024
Closed
This was referenced Jul 19, 2024
Closed
Closed
Closed
@snyk-io snyk-io bot mentioned this pull request Jul 27, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Aug 3, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 21, 2024
Open
@luizhp luizhp mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

@tux-tn tux-tn tux-tn approved these changes

Assignees
No one assigned
Labels
🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferdousulhaque @tux-tn @profnandaa